feat: Enrich /me endpoint with user roles
#2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Sep 19, 2023
api.planx.uk/modules/misc/docs.yaml
Outdated
| items: | ||
| type: object | ||
| properties: | ||
| teamId: |
There was a problem hiding this comment.
nit: it'd be super handy to have the teamSlug exposed here in addition to teamId - as I think we can then call this endpoint from the editor for signed-in users to populate their user menu in a meaningful way? Have an outdated wip version of this over here: https://github.com/theopensystemslab/planx-new/pull/2214/files#diff-a23b8e0cdc75fc858dc3a73983f67d257f78158596c37832202cf963efcf0a6aR267
DafyddLlyr
force-pushed
the
dp/me-api-endpoint
branch
from
a178d15 to
3396e2f
Compare
DafyddLlyr
added a commit
to theopensystemslab/planx-core
that referenced
this pull request
Sep 20, 2023
See comment here for context - theopensystemslab/planx-new#2224 (comment)
DafyddLlyr
force-pushed
the
dp/me-api-endpoint
branch
from
2a5353e to
822abfe
Compare
|
Blocked by #2226 |
DafyddLlyr
force-pushed
the
dp/use-api-context
branch
from
ea011d1 to
872891b
Compare
- Add tests - Move to module, use YAML docs - Return role details
DafyddLlyr
force-pushed
the
dp/me-api-endpoint
branch
from
822abfe to
988ad28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/me, makes this accessible to all logged in users/meand/(healthcheck) to a "misc" module in the API